Skip to content

Add clangd tidy checks - #409

Merged
97gamjak merged 52 commits into
devfrom
add_clangd-tidy_checks
Aug 1, 2026
Merged

Add clangd tidy checks#409
97gamjak merged 52 commits into
devfrom
add_clangd-tidy_checks

Conversation

@97gamjak

Copy link
Copy Markdown
Collaborator

closes #402

97gamjak added 30 commits July 29, 2026 08:23
@97gamjak
97gamjak requested review from ape33 and galjos July 30, 2026 15:25
@97gamjak 97gamjak added workflow Issues in the workflow cleanup labels Jul 30, 2026
@97gamjak
97gamjak marked this pull request as draft July 30, 2026 15:27
@pq-perf-bot

pq-perf-bot Bot commented Jul 30, 2026

Copy link
Copy Markdown

⚡ Performance (instruction count) — ✅ no regressions

per-benchmark breakdown
benchmark base Ir PR Ir Δ
bondedForces 41.46M 41.46M -0.00%
boxTransforms 10.67M 10.67M +0.00%
constraints 11.38M 11.38M -0.00%
coulombKernel 5.80M 5.80M +0.00%
forceKernel 15.33M 15.33M +0.00%
integrator 32.17M 32.17M -0.00%
kinetics 9.53M 9.53M +0.00%
linearAlgebra 2.07M 2.07M +0.00%
nonCoulombPairs 5.48M 5.48M -0.00%
shiftVector 5.81M 5.81M +0.00%
virial 11.64M 11.63M -0.07%

Deterministic callgrind instruction counts vs the base branch; gated at ±2%. Not wall-clock.

@codecov

codecov Bot commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.43590% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.82%. Comparing base (4387756) to head (d34410a).

Files with missing lines Patch % Lines
include/opt/optimizer/steepestDescent.hpp 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #409   +/-   ##
=======================================
  Coverage   89.82%   89.82%           
=======================================
  Files         294      294           
  Lines       11477    11480    +3     
  Branches     3599     3600    +1     
=======================================
+ Hits        10309    10312    +3     
  Misses       1126     1126           
  Partials       42       42           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@galjos

galjos commented Jul 31, 2026

Copy link
Copy Markdown
Member

Ready to review? @97gamjak

@97gamjak
97gamjak marked this pull request as ready for review July 31, 2026 06:25
@97gamjak

Copy link
Copy Markdown
Collaborator Author

Ready to review? @97gamjak

forgot to change status 🫣

Comment thread .github/workflows/lint.yml Outdated
Comment thread .github/workflows/lint.yml
Comment thread .github/workflows/lint.yml
@97gamjak
97gamjak requested a review from galjos July 31, 2026 17:50
galjos
galjos previously approved these changes Aug 1, 2026
@97gamjak
97gamjak merged commit 06ad202 into dev Aug 1, 2026
15 checks passed
@97gamjak
97gamjak deleted the add_clangd-tidy_checks branch August 1, 2026 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup workflow Issues in the workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants